feat: create new SafeDeclareStrictTypesRector #7814
+1,039
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
calebdw/push-oxpklwvkytpo
branch
5 times, most recently
from
dac996f to
e51df27
Compare
Member
|
Hi, thanks for such a fast kick off. Wow! Before I review, can you use a new Rector rule, e.g. Safe declare...Rector? People are used to current scope of the rule and ignore it as not safe. |
Contributor
Author
they should not be ignoring it because it's not part of any default set to ignore---if they wanted to use it then they would have needed to manually include it in their configs However, I can certainly create a new rule if you still think it's needed. |
Member
|
Indeed, but devs are lazy and it has a bad karma already. I would not recommend it to anyone :) Could you rename it? |
calebdw
force-pushed
the
calebdw/push-oxpklwvkytpo
branch
from
e51df27 to
fa3c381
Compare
calebdw
changed the title
Contributor
Author
|
@TomasVotruba, done! |
calebdw
force-pushed
the
calebdw/push-oxpklwvkytpo
branch
from
fa3c381 to
743d9a0
Compare
samsonasik
reviewed
Jan 19, 2026
...ation/Rector/StmtsAwareInterface/SafeDeclareStrictTypesRector/Fixture/closure_return.php.inc
Show resolved
Hide resolved
calebdw
force-pushed
the
calebdw/push-oxpklwvkytpo
branch
from
743d9a0 to
6f90d8b
Compare
samsonasik
reviewed
Jan 19, 2026
...ation/Rector/StmtsAwareInterface/SafeDeclareStrictTypesRector/Fixture/closure_return.php.inc
Show resolved
Hide resolved
samsonasik
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Motivation
See https://x.com/VotrubaT/status/2008248184540418398
Currently, the
DeclareStrictTypesRectorjust indiscriminately addsdeclare(strict_types=1)to all files. However:This PR creates a new rule (
SafeDeclareStrictTypesRector) that is (should be) completely safe and only adds strict types to the file when it won't break code. I've also added it to thecodeQualityruleset (but let me know if you'd rather it go elsewhere).Implementation
Basically, strict_types only affects calling code and prevents scalar type coercion in the following cases:
CallLikes andAttributesFunctionLikesThis PR adds a new service class (
StrictTypeSafetyChecker) that iterates through all the above and checks the type compatibility. If the file is completely safe then the refactor is performed, otherwise the file is skipped. I conservatively skip files when we can't be sure (e.g., dynamic calls, unpacks, etc.).Tip
All of the actual type checking is deferred to phpstan's
$declaredType->accepts($valueType, strictTypes: true)api which really makes things clean on our end.CC: @TomasVotruba
Thanks!